Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect diff output for multiple-choice options #129

Open
Yannik opened this issue Jun 24, 2024 · 2 comments
Open

Incorrect diff output for multiple-choice options #129

Yannik opened this issue Jun 24, 2024 · 2 comments

Comments

@Yannik
Copy link

Yannik commented Jun 24, 2024

SUMMARY

For some reason, whenever microsoft.ad.group does a change (e.g. changing the group members), it also reports the scope to be changed like this:

-scope: 1
+scope: global
ISSUE TYPE
  • Bug Report
COMPONENT NAME

microsoft.ad.group

ANSIBLE VERSION
ansible [core 2.16.7]
  config file = /home/yannik/projects/xxx/ansible/ansible.cfg
  configured module search path = ['/home/yannik/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.12/site-packages/ansible
  ansible collection location = /home/yannik/projects/xxx/ansible/vendor_collections
  executable location = /usr/local/bin/ansible
  python version = 3.12.3 (main, Apr 17 2024, 00:00:00) [GCC 13.2.1 20240316 (Red Hat 13.2.1-7)] (/usr/bin/python3)
  jinja version = 3.1.4
  libyaml = True
COLLECTION VERSION

1.6.0

@Yannik
Copy link
Author

Yannik commented Jun 24, 2024

This seems to be a general problem with options that have a limited number of choices.

Same thing happens with category:

-category: 1
+category: security

@Yannik Yannik changed the title microsoft.ad.group reporting scope being changed when it has not changed Incorrect diff output for multiple-choice options Jun 24, 2024
@jborean93
Copy link
Collaborator

Thanks for the bug report, the diff output generator is quite rudimentary as the data returned is the raw LDAP attribute value rather than the translated value the AD cmdlets may have added on top. We can certainly look into trying to improve situations like this but keep in mind there are probably other attributes where a similar problem occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants