Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v23.5.3 changes definition of platform tmpfs, maybe others? #242

Open
sjpb opened this issue Feb 20, 2024 · 2 comments
Open

Release v23.5.3 changes definition of platform tmpfs, maybe others? #242

sjpb opened this issue Feb 20, 2024 · 2 comments

Comments

@sjpb
Copy link

sjpb commented Feb 20, 2024

The changes to the task name: Create molecule instance(s) in e9d5649 in #187 changes the definition of the tmpfs parameter in platforms. This used to be a list of strs, now its a dict. I haven't gone digging to understand whether all the other parameters map across cleanly? But at least this release should be a new major version, IMO, it is not backward-compatible.

@sjpb
Copy link
Author

sjpb commented Feb 20, 2024

Oh and I think the tmpfs parameter no longer matches the docstring here: https://github.com/ansible-community/molecule-plugins/blob/main/src/molecule_plugins/podman/driver.py#L76?

@sjpb
Copy link
Author

sjpb commented Feb 20, 2024

Ok found one other breaking change: this worked in v23.5.0 and doesn't work now:

platforms:
  - name: testohpc-login-0
    command: "/bin/bash -c 'dnf -y install systemd && /sbin/init'" # not in RL9 image

Inspecting the container startup shows that something about the quoting needs changing to fix it. OK this might be a bit of a pathological case but it did work!

I admit this

sjpb added a commit to stackhpc/ansible-role-openhpc that referenced this issue Feb 20, 2024
sjpb added a commit to stackhpc/ansible-role-openhpc that referenced this issue Feb 20, 2024
* add RL9/OHPCv3 repos

* FIXME: use crb instead of powertools

* fix apptainer/singularity clash: openhpc/ohpc#1889 (comment)

* FIXME: add cgroup.conf

* FIXME: don't use outdated pgid for proctracktype

* bump CI to include RL9

* fix linter errors

* fix molecule instance creation for RL9

* bump RL8 CI image

* fix powertools/crb repos

* fix container startup

* bump GH actions version to avoid node version warning in CI

* minimise PR differences

* include cgroup.conf template from upstream

* pin molecule-podman to avoid ansible-community/molecule-plugins#242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant