From 6f4c55fcf25e041e70feb86635a84ddcae68b188 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=84=9A=E6=8C=87=E5=AF=BC?= Date: Fri, 22 Mar 2024 10:02:38 +0800 Subject: [PATCH] fix: qr code scan tip text for universal protocol (#677) Co-authored-by: tingzhao.ytz --- .changeset/smooth-trees-stare.md | 6 ++++++ packages/common/src/locale/en_US.ts | 1 + packages/common/src/locale/zh_CN.ts | 1 + packages/common/src/types.ts | 1 + packages/web3/src/connect-modal/components/QrCode.tsx | 4 +++- .../web3/src/connector/__tests__/quick-connect.test.tsx | 6 ++++++ 6 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 .changeset/smooth-trees-stare.md diff --git a/.changeset/smooth-trees-stare.md b/.changeset/smooth-trees-stare.md new file mode 100644 index 000000000..7577bab45 --- /dev/null +++ b/.changeset/smooth-trees-stare.md @@ -0,0 +1,6 @@ +--- +'@ant-design/web3-common': patch +'@ant-design/web3': patch +--- + +fix: qr code scan tip text for universal protocol diff --git a/packages/common/src/locale/en_US.ts b/packages/common/src/locale/en_US.ts index 6f202a0ec..b86cd1dad 100644 --- a/packages/common/src/locale/en_US.ts +++ b/packages/common/src/locale/en_US.ts @@ -29,6 +29,7 @@ const localeValues: RequiredLocale = { 'Select a wallet on the left to get started with a different wallet provider.', qrCodePanelTitleForDownload: 'Download {walletName}', qrCodePanelTitleForScan: 'Scan with {walletName}', + qrCodePanelTitleForUniversalProtocol: 'Scan with your wallet', qrCodePanelLinkForDownload: 'Click to go to the download page', qrCodePanelLinkForConnect: 'Click to connect directly', qrCodePanelDownloadTipForReady: 'Scan the QR code to download the wallet.', diff --git a/packages/common/src/locale/zh_CN.ts b/packages/common/src/locale/zh_CN.ts index d01c74138..e5148a14c 100644 --- a/packages/common/src/locale/zh_CN.ts +++ b/packages/common/src/locale/zh_CN.ts @@ -27,6 +27,7 @@ const localeValues: RequiredLocale = { getWalletPanelInfoDesc: '在左侧选择钱包,以开始使用不同的钱包提供商。', qrCodePanelTitleForDownload: '下载 {walletName}', qrCodePanelTitleForScan: '使用 {walletName} 扫描', + qrCodePanelTitleForUniversalProtocol: '使用你的钱包扫描', qrCodePanelLinkForDownload: '点击前往下载页面', qrCodePanelLinkForConnect: '点击直接连接', qrCodePanelDownloadTipForReady: '扫描二维码下载钱包', diff --git a/packages/common/src/types.ts b/packages/common/src/types.ts index 5d44eb01c..d640e1544 100644 --- a/packages/common/src/types.ts +++ b/packages/common/src/types.ts @@ -217,6 +217,7 @@ export interface RequiredLocale { getWalletPanelInfoDesc: string; qrCodePanelTitleForDownload: string; qrCodePanelTitleForScan: string; + qrCodePanelTitleForUniversalProtocol: string; qrCodePanelLinkForDownload: string; qrCodePanelLinkForConnect: string; qrCodePanelDownloadTipForReady: string; diff --git a/packages/web3/src/connect-modal/components/QrCode.tsx b/packages/web3/src/connect-modal/components/QrCode.tsx index de9d4e182..89b08adc2 100644 --- a/packages/web3/src/connect-modal/components/QrCode.tsx +++ b/packages/web3/src/connect-modal/components/QrCode.tsx @@ -48,7 +48,9 @@ const QrCode: React.FC = (props) => { title={getMessage( download ? localeMessage.qrCodePanelTitleForDownload - : localeMessage.qrCodePanelTitleForScan, + : wallet.universalProtocol + ? localeMessage.qrCodePanelTitleForUniversalProtocol + : localeMessage.qrCodePanelTitleForScan, { walletName: wallet.name, }, diff --git a/packages/web3/src/connector/__tests__/quick-connect.test.tsx b/packages/web3/src/connector/__tests__/quick-connect.test.tsx index e8b4d9c00..6b10f1d63 100644 --- a/packages/web3/src/connector/__tests__/quick-connect.test.tsx +++ b/packages/web3/src/connector/__tests__/quick-connect.test.tsx @@ -109,6 +109,12 @@ describe('Connector quick connect', () => { expect(baseElement.querySelector('.ant-btn-loading-icon')).toBeTruthy(); expect(baseElement.querySelector('.ant-modal-body')).toBeTruthy(); expect(baseElement.querySelector('.ant-web3-connect-modal-qr-code')).toBeTruthy(); + expect(baseElement.querySelector('.ant-web3-connect-modal-get-wallet-tip')?.textContent).toBe( + "Don't know WalletConnect?", + ); + expect( + baseElement.querySelector('.ant-web3-connect-modal-main-panel-header-title')?.textContent, + ).toBe('Scan with your wallet'); }); });