Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"css should not be empty" error #37

Open
mihajlija opened this issue May 23, 2019 · 0 comments
Open

"css should not be empty" error #37

mihajlija opened this issue May 23, 2019 · 0 comments

Comments

@mihajlija
Copy link

Hi, I'm having the same problem as #31 and I'd really appreciate some help. I have a much simpler config so I figured I'd open a separate issue.

I'm using Bootstrap with a little bit of custom CSS and I'm injecting content in the DOM with JavaScript. This plugin runs last in my webpack config.

  1. The code: Glitch app
  2. Steps to reproduce:
  • Run webpack in Glitch console
  1. Expected behavior: Critical detects the CSS from index.html
  2. What happens: I get "css should not be empty" error even though it's seemingly in the right place (/public/main.css) and not empty
  3. Temporary fix: Explicitly specifying the CSS file in the plugin config

@thescientist13 mentioned that the issue might be due to empty HTML at the time of evaluation, but it's not quite empty, there is an h1 element there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant