Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadPool metrics bound to default global registry, may not be getting reported #5006

Open
dlmarion opened this issue Oct 22, 2024 · 1 comment
Assignees
Milestone

Comments

@dlmarion
Copy link
Contributor

ThreadPool metrics are bound to the global registry here. I'm not sure if these meters will get published via the pluggable MeterRegistry implementations or not. Need to test for the presence of metrics with names starting with executor. to determine if they are or are not.

@dlmarion dlmarion added this to the 2.1.4 milestone Oct 22, 2024
@dlmarion dlmarion self-assigned this Oct 22, 2024
@ddanielr
Copy link
Contributor

Was looking into some other metric issues earlier and happened to see the executor metrics with 2.1.4.

Started a local 2.1.4 accumulo cluster with general.micrometer.enabled=true which uses the LoggingMeterRegistryFactory by default.

Checked the compactor logs and saw the following metrics:

executor.completed{host=localhost,instance.name=uno,name=accumulo.pool.general.server,port=9134,process.name=compactor} throughput=0.016667 tasks/s
executor.active{host=localhost,instance.name=uno,name=accumulo.poolcompactor.client,port=9134,process.name=compactor} value=0 threads
executor.active{host=localhost,instance.name=uno,name=accumulo.pool.general.server,port=9134,process.name=compactor} value=0 threads
executor.pool.core{host=localhost,instance.name=uno,name=accumulo.pool.general.server,port=9134,process.name=compactor} value=1 threads
executor.pool.core{host=localhost,instance.name=uno,name=accumulo.poolcompactor.client,port=9134,process.name=compactor} value=1 threads
executor.pool.max{host=localhost,instance.name=uno,name=accumulo.poolcompactor.client,port=9134,process.name=compactor} value=1 threads
executor.pool.max{host=localhost,instance.name=uno,name=accumulo.pool.general.server,port=9134,process.name=compactor} value=2147483647 threads
executor.pool.size{host=localhost,instance.name=uno,name=accumulo.pool.general.server,port=9134,process.name=compactor} value=1 threads
executor.pool.size{host=localhost,instance.name=uno,name=accumulo.poolcompactor.client,port=9134,process.name=compactor} value=0 threads
executor.queue.remaining{host=localhost,instance.name=uno,name=accumulo.pool.general.server,port=9134,process.name=compactor} value=2147483647 tasks
executor.queue.remaining{host=localhost,instance.name=uno,name=accumulo.poolcompactor.client,port=9134,process.name=compactor} value=2147483647 tasks
executor.queued{host=localhost,instance.name=uno,name=accumulo.poolcompactor.client,port=9134,process.name=compactor} value=0 tasks
executor.queued{host=localhost,instance.name=uno,name=accumulo.pool.general.server,port=9134,process.name=compactor} value=1 tasks

Do you want to add a specific test for the executor prefix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants