Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Update Deploy docker image script and documentation for GitHub Action built candidate #27521

Closed
15 tasks
Abacn opened this issue Jul 17, 2023 · 0 comments · Fixed by #27548
Closed
15 tasks

Comments

@Abacn
Copy link
Contributor

Abacn commented Jul 17, 2023

What needs to happen?

The current publish_docker_images script assumes rc images existed locally, It fetches IMAGES via docker images command which only looks up locally existed images (either built or pulled). As we have migrated to use github action to build rc images, we need to figure out a way to fetch rc images from remote.

A possible way is change the line to

IMAGES=$(docker search apache/beam_ --format "{{.Name}}" --limit 100)

then inside the loop,

if ! docker pull "${IMAGE}:${RELEASE}${RC_VERSION}" ; then
  continue
fi

this has two minor issue though

  • docker cli does not support search image having specific tag, nor sort by update date
  • the default --limit is 25, causing some images not get listed. We can bump --limit of course, but as time goes and more image name added, it can be risky to miss some image

Please comment if there are better way to do that.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant