Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Calls to pipeline.options. in Beam codebase cause unactionable deprecation warning for users. #28236

Closed
1 of 15 tasks
tvalentyn opened this issue Aug 30, 2023 · 6 comments · Fixed by #28774
Closed
1 of 15 tasks
Assignees
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. good first issue P3 python

Comments

@tvalentyn
Copy link
Contributor

What happened?

Deprecation warning was added in : #2801.

Quick search for places where this is used: https://github.com/search?q=repo%3Aapache%2Fbeam+%22pipeline.options.%22&type=code

Given that we use the option in Beam code and removing the Pipeline.options() would be a breaking change that we won't do anytime soon (after all we didn't do it for 6 years)..., I think it's fine to remove this warning.

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@tvalentyn
Copy link
Contributor Author

tvalentyn commented Aug 30, 2023

We can remove the warning https://github.com/apache/beam/blob/d359758c3ac226e5ae9920105c3cd4a10f37c4b8/sdks/python/apache_beam/pipeline.py

and also remove silences like: https://github.com/apache/beam/blob/c7b13f90874940dd0e897eab472e81f70627e91f/sdks/python/apache_beam/runners/interactive/recording_manager.py

This should be a simple cleanup.

@JoeCMoore
Copy link

I second this. The warning is misleading if you aren't up to speed with what it originates from.

@AtharvaShekatkar
Copy link

.take-issue

@aku019
Copy link
Contributor

aku019 commented Oct 2, 2023

.take-issue

@aku019
Copy link
Contributor

aku019 commented Oct 2, 2023

#28774

Hi Guys, look into this PR and share your views.

This is my first PR , so guidance will be valued. Thanks!

@github-actions github-actions bot added this to the 2.52.0 Release milestone Oct 2, 2023
@tvalentyn tvalentyn added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Oct 2, 2023
@tvalentyn
Copy link
Contributor Author

Merged, thanks a lot! Welcome to Apache Beam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. good first issue P3 python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants