-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump snappy-java version to 1.1.10.4 #28655
Conversation
beam_PreCommit_Java_Amazon-Web-Services2_IO_Direct |
Run Java_Pulsar_IO_Direct |
Run Java_Amazon-Web-Services_IO_Direct PreCommit |
Run Java_Amazon-Web-Services2_IO_Direct PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #28655 +/- ##
=======================================
Coverage 72.20% 72.20%
=======================================
Files 684 684
Lines 101141 101141
=======================================
+ Hits 73029 73030 +1
+ Misses 26534 26533 -1
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Run Java_Pulsar_IO_Direct PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Noting that this surprisingly ended up being a backwards incompatible change since it changed the serialized form of the SnappyCoder so now anything which uses SnappyCoder can't be upgraded from |
Documenting this in #32753 |
Upgrade due to GitHub security advisory: GHSA-55g7-9cwv-5qfv