-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flaky Notebooks tests #29217
Remove flaky Notebooks tests #29217
Conversation
Signed-off-by: Jeffrey Kinard <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29217 +/- ##
=======================================
Coverage 38.32% 38.32%
=======================================
Files 688 688
Lines 101846 101846
=======================================
Hits 39032 39032
Misses 61233 61233
Partials 1581 1581
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
|
Could you give some context on this? Where have we seen the flakes? Do we have adequate coverage without this? |
Reminder, please take a look at this pr: @damccorm |
waiting on author |
@damccorm These flakes block notebooks release and perform no real testing of the code itself. They essentially test the fonts and formatting of the output of the notebook cells |
Are there actually other tests in https://github.com/apache/beam/tree/3f434f07053d5a73be202cb6d7d70abca200f463/sdks/python/apache_beam/runners/interactive/testing I ask for 2 reasons:
That is testing something, even if its not the most effective test for that. Do we understand why they're flaky? Is it something that could be fixed? cc/ @kevingg who may have thoughts here |
Reminder, please take a look at this pr: @damccorm |
Closing as these tests have not been an issue in a while. |
This PR removes the flaky screenshots tests from Notebooks IT suite.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.