Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for Go custom container builds, link from 2.55.0 release notes. #30290

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Feb 12, 2024

Add a message to 2.55.0's Breaking Changes regarding the Go container moving to distroless.

While the existing instructions for
https://beam.apache.org/documentation/runtime/environments/#modify-existing-base-image do work, the simplicity of Go's handling in this case is valuable to emphasize.

Staging:
https://apache-beam-website-pull-requests.storage.googleapis.com/30290/documentation/runtime/environments/index.html#from-scratch-go


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Contributor Author

R: @liferoad

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

CHANGES.md Outdated Show resolved Hide resolved
@lostluck
Copy link
Contributor Author

I got into a groove and went and figured out the right custom container instructions, so no stopgap required.
Did you know Beam works just fine on Alpine when the container is set up properly? (As an example.)

@lostluck lostluck changed the title Stopgap message in release notes. Add instructions for Go custom container builds, link from 2.55.0 release notes. Feb 13, 2024
@liferoad
Copy link
Collaborator

I got into a groove and went and figured out the right custom container instructions, so no stopgap required. Did you know Beam works just fine on Alpine when the container is set up properly? (As an example.)

I never try that but it should work.

BTW: we can also add https://cloud.google.com/dataflow/docs/guides/using-custom-containers to the md file if users need more information about custom containers.

@lostluck
Copy link
Contributor Author

BTW: we can also add https://cloud.google.com/dataflow/docs/guides/using-custom-containers to the md file if users need more information about custom containers.

That file just links to the page I'm already linking to. It's also weird to link to the Dataflow pages from a Beam release for a non-dataflow feature.

@liferoad
Copy link
Collaborator

I mean adding this to website/www/site/content/en/documentation/runtime/environments.md if users want to learn more how to do this in general. But it is fine not to do this if you feel it is strange. :)

@lostluck
Copy link
Contributor Author

I don't feel it's reasonable to conflate adding that link to this PR. I have no idea where I'd put it.

I've always found our strategy of essentially putting general Beam content on the Dataflow pages to be baffling, vs improving the content on the Beam pages.

@lostluck lostluck merged commit 9a4e114 into apache:master Feb 13, 2024
6 checks passed
@lostluck lostluck deleted the disclaimerDistroless branch February 13, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants