Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flink portable client configurations #31188

Merged
merged 2 commits into from
May 30, 2024

Conversation

AyWa
Copy link
Contributor

@AyWa AyWa commented May 6, 2024

Descriptions

Previously made an attempt to solve that in https://github.com/apache/beam/pull/28068/files, but at that time, I didn't have time to follow up.
I will try to contribute better to beam (especially for flink runner).

In this PR, we make

  • FlinkPortableClientEntryPoint accept parameters that JobServerDriver can handle.
  • Add arguments for timeout. (We have this issue with JobManager that have low cpu assigned in k8s).

Copy link
Contributor

github-actions bot commented May 6, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@AyWa AyWa force-pushed the feat/flink-portable-client-artifacts branch from 0af945d to d5957f8 Compare May 12, 2024 13:23
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jaehyeon-kim
Copy link
Contributor

Hi @AyWa and @damondouglas

I just wonder when this feature may be available. I need to increase the job submission timeout as my python beam pipeline keeps failing due to the 30 seconds limit.

Or can I have a temporary jar file (beam-runners-flink-1.17-job-server-2.56.0.jar) with this feature until it gets included?

Cheers,
Jaehyeon

@AyWa
Copy link
Contributor Author

AyWa commented May 20, 2024

Hi @AyWa and @damondouglas

I just wonder when this feature may be available. I need to increase the job submission timeout as my python beam pipeline keeps failing due to the 30 seconds limit.

Or can I have a temporary jar file (beam-runners-flink-1.17-job-server-2.56.0.jar) with this feature until it gets included?

Cheers, Jaehyeon

Hey,

It is possible to build the jar, I am a bit busy today, but I will try to come back to you soon.

A temporary option is to increase cpu allocation of the job manager. (It is how I temporary fixed it in my k8s cluster)

@jaehyeon-kim
Copy link
Contributor

Hi @AyWa and @damondouglas
I just wonder when this feature may be available. I need to increase the job submission timeout as my python beam pipeline keeps failing due to the 30 seconds limit.
Or can I have a temporary jar file (beam-runners-flink-1.17-job-server-2.56.0.jar) with this feature until it gets included?
Cheers, Jaehyeon

Hey,

It is possible to build the jar, I am a bit busy today, but I will try to come back to you soon.

A temporary option is to increase cpu allocation of the job manager. (It is how I temporary fixed it in my k8s cluster)

Hi @AyWa

Thanks for your reply. I'm trying to deploy a python pipeline to a minikube cluster and I don't have much luck by adjusting cpu allocation. It'll be great if the jar file is shared or I'm informed of how to build it.

Cheers,
Jaehyeon

@AyWa
Copy link
Contributor Author

AyWa commented May 20, 2024

Hi @AyWa and @damondouglas
I just wonder when this feature may be available. I need to increase the job submission timeout as my python beam pipeline keeps failing due to the 30 seconds limit.
Or can I have a temporary jar file (beam-runners-flink-1.17-job-server-2.56.0.jar) with this feature until it gets included?
Cheers, Jaehyeon

Hey,
It is possible to build the jar, I am a bit busy today, but I will try to come back to you soon.
A temporary option is to increase cpu allocation of the job manager. (It is how I temporary fixed it in my k8s cluster)

Hi @AyWa

Thanks for your reply. I'm trying to deploy a python pipeline to a minikube cluster and I don't have much luck by adjusting cpu allocation. It'll be great if the jar file is shared or I'm informed of how to build it.

Cheers, Jaehyeon

Not sure it is the best way, but this is how I am doing:
You can run ./gradlew :runners:flink:1.16:job-server-container:docker on my branch. It will create a docker image (change the flink version that you are targetting).
In docker file of flink, I do a docker copy of /opt/apache/beam_job_server

Copy link
Contributor

Reminder, please take a look at this pr: @damondouglas

Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @AyWa for your contribution!

@damondouglas damondouglas merged commit 3cadc83 into apache:master May 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants