[prism] Support Gauge Metrics #31928
Milestone
Comments
3 tasks
lostluck
added a commit
that referenced
this issue
Aug 15, 2024
* Update Generated Go Protos * [prism] Add stringset and gauge metrics * lint + tests --------- Co-authored-by: lostluck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to #31927, but implement Gauge Metrics.
A metric accumulator will need to be added for the type in prism:
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/prism/internal/jobservices/metrics.go#L357
And adding the type to the accumulator factory list:
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/prism/internal/jobservices/metrics.go#L168
Specifically with the right URNs and coders:
https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/metrics.proto#L520
Once unfiltered, this will allow the following Java Validates Runner tests to pass.
MetricsTest.testCommittedGaugeMetrics
MetricsTest.testAttemptedGaugeMetrics
The text was updated successfully, but these errors were encountered: