Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update cython requirement from <1 to <4 in /sdks/python (#320… #32110

Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 8, 2024

…87)"

This reverts commit 502c728.

This probably shouldn't have been done without some conversation on the mailing list (see #32034 and

# Don't upgrade to Cython 3.x, until it's released, stable and we have consensus
) - I'm not sure why this got reopened FWIW


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

damccorm commented Aug 8, 2024

R: @jrmccluskey

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@jrmccluskey
Copy link
Contributor

oops, this just got thrown in with a shuffle of dependency upgrade PRs that I got this week. SGTM

@damccorm
Copy link
Contributor Author

damccorm commented Aug 8, 2024

No problem, I just happened to notice it. I think we want to do this anyways (and hope to send something out to the dev list in the next weekish), but it is not obvious to me whether we can do it blindly or not (@robertwb probably has a better idea)

@jrmccluskey jrmccluskey merged commit 18849de into master Aug 8, 2024
93 checks passed
@damccorm damccorm deleted the revert-32087-dependabot/pip/sdks/python/cython-lt-4 branch October 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants