Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Apache Beam to use Cython 3.x. #32112

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Aug 8, 2024

Cython 3 has been out for over a year now (with the first pre-release predating that by several years).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this was on my backlog :)

@robertwb
Copy link
Contributor Author

robertwb commented Aug 8, 2024

I think the Could not retrieve licences for packages ['scikit-learn'] errors are irrelevant.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Many files, including all of those that would be likely to have issues with
string/bytes, were already setting language level to 3.

Taking a pass through the compiled files, I did not see any incompatibilities.

Tests seem to be fine as well.
Not running script due to pre-exising issues.
@tvalentyn
Copy link
Contributor

@robertwb Does your recommendation in https://github.com/apache/beam/pull/27536/files#r1267273865 still apply?

@robertwb
Copy link
Contributor Author

robertwb commented Aug 8, 2024

Good call. I did take a pass over the pxd files, but forgot about the nogil caveat. Looks like we don't use that much, but added the one case I found. (Most of the time we were either explicitly using except or returning a Python object, and even where not it's numeric so should be fast.)

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@robertwb robertwb merged commit 49e98e5 into apache:master Aug 9, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants