-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Apache Beam to use Cython 3.x. #32112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this was on my backlog :)
I think the |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Many files, including all of those that would be likely to have issues with string/bytes, were already setting language level to 3. Taking a pass through the compiled files, I did not see any incompatibilities. Tests seem to be fine as well.
Not running script due to pre-exising issues.
@robertwb Does your recommendation in https://github.com/apache/beam/pull/27536/files#r1267273865 still apply? |
Good call. I did take a pass over the pxd files, but forgot about the nogil caveat. Looks like we don't use that much, but added the one case I found. (Most of the time we were either explicitly using except or returning a Python object, and even where not it's numeric so should be fast.) |
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Cython 3 has been out for over a year now (with the first pre-release predating that by several years).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.