Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prism] Support BundleFinalization DoFn parameter #32425

Merged
merged 11 commits into from
Sep 21, 2024

Conversation

damondouglas
Copy link
Contributor

This PR closes #31912 by adding support for bundle finalization via the beam.BundleFinalization DoFn parameter.

With Prism running, to validate Java tests against Prism runner:

TEST=org.apache.beam.sdk.transforms.SplittableDoFnTest
./gradlew :runners:portability:java:ulrLoopbackValidatesRunnerTests -PjobEndpoint=localhost:8073 --tests="$TEST"

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas
Copy link
Contributor Author

R: @lostluck

@damondouglas damondouglas marked this pull request as ready for review September 11, 2024 01:32
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damondouglas damondouglas marked this pull request as draft September 11, 2024 17:58
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments since I know you have other plans for that remaining test right now.

@damondouglas damondouglas marked this pull request as ready for review September 19, 2024 19:21
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes and refactoring suggestions!

Please feel free to merge after you've made them, if you don't want another look.

sdks/go/test/integration/primitives/pardo.go Outdated Show resolved Hide resolved
sdks/go/test/integration/primitives/pardo.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 57.32%. Comparing base (2a7755b) to head (2690975).
Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
...o/pkg/beam/runners/prism/internal/worker/bundle.go 0.00% 9 Missing ⚠️
sdks/go/pkg/beam/runners/prism/internal/stage.go 42.85% 3 Missing and 1 partial ⚠️
sdks/go/pkg/beam/core/runtime/graphx/translate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32425      +/-   ##
============================================
- Coverage     57.33%   57.32%   -0.01%     
  Complexity     1474     1474              
============================================
  Files           964      965       +1     
  Lines        153301   153467     +166     
  Branches       1076     1076              
============================================
+ Hits          87896    87981      +85     
- Misses        63201    63281      +80     
- Partials       2204     2205       +1     
Flag Coverage Δ
go 34.65% <26.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damondouglas
Copy link
Contributor Author

damondouglas commented Sep 20, 2024

@lostluck The codecov/patch report shows stuff that didn't seem sensible to write tests for. Should I just go ahead and merge this you think?

@lostluck
Copy link
Contributor

Agreed. Please go ahead

@lostluck lostluck merged commit 986ee96 into apache:master Sep 21, 2024
7 checks passed
@damondouglas damondouglas deleted the prism-bundle-finalizer branch September 25, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prism] Support Bundle Finalization
2 participants