Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schrodinger logo #32525

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Add schrodinger logo #32525

merged 2 commits into from
Sep 22, 2024

Conversation

hjtran
Copy link
Contributor

@hjtran hjtran commented Sep 20, 2024

We've been using Beam for the past year and it's been great!

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @liferoad for label website.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad
Copy link
Collaborator

Thanks a lot!

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like the directory is off, but its great to hear that Beam has been working for you!

@@ -0,0 +1,19 @@
---
title: "Schrodinger"
icon: /images/logos/powered-by/schrodinger.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, but it looks like the logo ended up in the wrong directory (sdks/python instead of https://github.com/apache/beam/tree/master/website/www/site/static/images/logos/powered-by)

@github-actions github-actions bot added python and removed python labels Sep 22, 2024
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 6adb145 into apache:master Sep 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants