Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assert into pipeline #32530

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Move assert into pipeline #32530

merged 3 commits into from
Sep 22, 2024

Conversation

damccorm
Copy link
Contributor

This assert was inadvertently ignored, until #30771 exposed that and turned the meaningless assert into an error. This broke the python postcommit - https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python.yml - this fixes the problem


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.89%. Comparing base (818966c) to head (50dd048).

Files with missing lines Patch % Lines
sdks/python/apache_beam/ml/gcp/visionml_test_it.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #32530   +/-   ##
=========================================
  Coverage     58.89%   58.89%           
  Complexity     3071     3071           
=========================================
  Files          1129     1129           
  Lines        173950   173959    +9     
  Branches       3318     3318           
=========================================
+ Hits         102442   102452   +10     
+ Misses        68171    68170    -1     
  Partials       3337     3337           
Flag Coverage Δ
python 81.57% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damccorm damccorm marked this pull request as ready for review September 22, 2024 23:39
@damccorm
Copy link
Contributor Author

R: @liferoad @Abacn

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@liferoad liferoad merged commit 7c382df into master Sep 22, 2024
97 checks passed
@damccorm damccorm deleted the users/damccorm/assert branch September 23, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants