-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beam logging in playground for Python #32740
Conversation
R: @robertwb |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
R: @lostluck ? |
@liferoad - Who might be a good person to review this change. My 2 cents: To be honest, I am not sure what is a good change here. People use playground to learn, and logs help learning. But too much logging does not really help with learning. |
@hjtran could you provide some examples to show the logging issue here? |
@hjtran we do not have a way to control the logging levels now with Playground. With your PR, it will remove all the logs. |
Can we at least adjust this PR to ERROR? I think it is needed if users play with the wrong code. |
Changed! |
https://github.com/apache/beam/actions/runs/11451588425/job/31878797880?pr=32740 I tried twice but both failed. |
Any guess as to why the "Operation was canceled"? I'm not sure how to troubleshoot this |
Does this run locally? |
FWIW, I totally agree that these logs are quite unhelpful, regardless of if you're in the playground or not. |
How do I retrigger the precommit here? Looks like @volatilemolotov fixed the issue that caused the cancellation of the precommit runs |
Run Playground PreCommit |
@hjtran It will not be able to trigger by comment now as the PR is before my updates. Easiest way is to just add a new commit and push to re-trigger. |
Bump @liferoad |
I get a lot of complaints about all the logging in Beam playground for python examples. It really drowns out any output that might be coming from the examples.
I attempted to just remove the logging altogether for the python examples here, though I have no way of testing it.
My rationale is that the Beam playground environment doesn't really make sense to have logging for. If something goes wrong with an example, it makes a lot more sense to just copy and paste the example into your local Beam environment and debug it there (and optionally turn on logging in your own environment).