Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to adjust ReadChangeStream API timeout to allow longer timeout for longer checkpoint durations #33001

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tonytanger
Copy link
Contributor

This is useful if the runner's checkpoint duration is longer than 15s which is the default we set for ReadChangeStream API. If the runner's checkpoint duration is longer than 15s, the ReadChangeStream request will get deadline exceeded error before the runner initiated. This will cause the run to fail and return to the previous checkpoint.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@tonytanger
Copy link
Contributor Author

@jackdingilian for Bigtable review

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

…eout for longer checkpoint durations

Change-Id: Ia61388bed5997b7138b15a014d6370d49cbf5277
Change-Id: If34866637045314dfeef1807122cc34b97cc5ddc
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @johnjcasey for label io.
R: @mutianf for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants