-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]Delete useless code check_set_nullable() #41739
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
ClickBench: Total hot run time: 32.54 s
|
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40676 ms
|
TPC-DS: Total hot run time: 191712 ms
|
ClickBench: Total hot run time: 32.33 s
|
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40591 ms
|
TPC-DS: Total hot run time: 191215 ms
|
ClickBench: Total hot run time: 32.29 s
|
.gitignore
Outdated
@@ -143,3 +143,4 @@ docker/runtime/be/resource/apache-doris/ | |||
compile_commands.json | |||
.github | |||
|
|||
core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't commit this too. or just core-*
may be acceptable
// under the License. | ||
|
||
suite("test_regexp_replace") { | ||
sql "SET enable_nereids_planner=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u don't need to set these to session variables now. in master branch now we only have nereids planner and no other
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TPC-H: Total hot run time: 41009 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 191413 ms
|
ClickBench: Total hot run time: 32.12 s
|
Proposed changes
Issue Number: close #xxx