From d450d7d7e83908940cf84ee081078c6c40a1fa89 Mon Sep 17 00:00:00 2001 From: PAN <46820719+pandalee99@users.noreply.github.com> Date: Thu, 27 Jun 2024 16:08:47 +0800 Subject: [PATCH] fix(doc): codestyle version in python (#1706) ## What does this PR do? In fact, in Python's code style, here's the hint ```bash pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear ``` But there is no version of click black actually depends on click, by default, our click is the latest, so there is a problem of version inconsistency, and then the developer may not know what version is needed, and may upgrade black. Unfortunately, the ci/cd monitoring results are not the same for different versions of black I think it's the right thing to do to avoid ambiguity ```bash pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear click==8.0.2 ``` ## Related issues https://github.com/apache/fury/blob/main/CONTRIBUTING.md ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 18f133711b..152747ea54 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -96,7 +96,7 @@ mvn checkstyle:check ```bash cd python # install dependencies fro styling -pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear +pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear click==8.0.2 # format python code black pyfury ```