Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add black formatting github hook #19

Open
royari opened this issue Dec 13, 2023 · 2 comments · May be fixed by #27
Open

Add black formatting github hook #19

royari opened this issue Dec 13, 2023 · 2 comments · May be fixed by #27
Assignees
@arushi-08
Labels
good first issue Good for newcomers

Comments

@royari
Copy link
Member

royari commented Dec 13, 2023 •
edited
Loading

https://towardsdatascience.com/keep-your-code-clean-using-black-pylint-git-hooks-pre-commit-baf6991f7376

Expected behavior:
add a pre-commit hook which does the following

  • Check for formatting issue when git commit is used.
  • runs black to format if issue is found else exits
@royari royari added the good first issue Good for newcomers label Dec 13, 2023
@GondorGitaros GondorGitaros mentioned this issue Dec 13, 2023
Closed
@arushi-08
Copy link

Hi @royari can I take on this?

@royari
Copy link
Member Author

royari commented Sep 18, 2024

Absolutely!

@arushi-08 arushi-08 linked a pull request Oct 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arushi-08 arushi-08

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add black git hooks arushi-08/incubator-resilientdb-python-sdk
2 participants
@royari @arushi-08