Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation lacks explanation of service.enableDegrade property #6347

Open
1 task done
linghengqian opened this issue Feb 16, 2024 · 2 comments · Fixed by #6350 or apache/incubator-seata-website#838
Open
1 task done
Assignees

Comments

@linghengqian
Copy link
Member

  • I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

service {
  #transaction service group mapping
  vgroupMapping.default_tx_group = "default"
  #only support when registry.type=file, please don't set multiple addresses
  default.grouplist = "127.0.0.1:8091"
  #degrade, current not support
  enableDegrade = false
  #disable seata
  disableGlobalTransaction = false
}
key desc remark
service.disableGlobalTransaction service.enableDegrade transaction Group (Appendix 1)
key desc remark
service.enableDegrade 降级开关(待实现)默认false。业务侧根据连续错误数自动降级不走seata事务
key desc remark
client.tm.degradeCheck 降级开关 默认false。业务侧根据连续错误数自动降级不走seata事务(详细介绍请阅读附录6)

Ⅱ. Describe what happened

  • Null.

Ⅲ. Describe what you expected to happen

  • Possible documentation updates or template updates.

Ⅳ. How to reproduce it (as minimally and precisely as possible)

  1. Open https://seata.apache.org/docs/user/configurations/ .
  2. Open https://github.com/apache/incubator-seata/blob/v2.0.0/script/client/conf/file.conf .
  3. Open https://github.com/apache/incubator-seata/blob/2.x/script/client/conf/file.conf .

Minimal yet complete reproducer code (or URL to code):

  • Null.

Ⅴ. Anything else we need to know?

  • Null.

Ⅵ. Environment:

  • JDK version(e.g. java -version):
openjdk version "21.0.2" 2024-01-16
OpenJDK Runtime Environment GraalVM CE 21.0.2+13.1 (build 21.0.2+13-jvmci-23.1-b30)
OpenJDK 64-Bit Server VM GraalVM CE 21.0.2+13.1 (build 21.0.2+13-jvmci-23.1-b30, mixed mode, sharing)
  • Seata client/server version: 2.0.0
  • Database version: MySQL Server 8.3.0
  • OS(e.g. uname -a): Linux DESKTOP-J7M76VH 5.15.133.1-microsoft-standard-WSL2 #1 SMP Thu Oct 5 21:02:42 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
  • Others: Null
@slievrly
Copy link
Member

@linghengqian I apologize for any inconvenience this may have caused you, and thank you for your feedback.

  1. The service.enableDegrade has been deprecated, and I have removed it from both the code and the sample configuration files.
  2. Seata currently supports simulating empty transaction commit during runtime to decide on transaction degrade or upgrade. The tm.degradeCheck configuration (default is false) indicates whether to enable this feature. The tm.degradeCheckPeriod configuration (default is 2s) specifies the interval for the periodic detection. The tm.degradeCheckAllowTimes configuration (default is 10) represents the threshold of consecutive events required to trigger degrade or upgrade.

Additionally, the code for degrade was mistakenly deleted before and will be fixed in version 2.1.

@linghengqian
Copy link
Member Author

  • Since seata 2.2 has been released and service.enableDegrade has been removed, can I close the current issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants