Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub connector needs a PubSubConfig but that class is deprecated #810

Open
DavidCorral94 opened this issue Sep 18, 2024 · 2 comments
Open

Comments

@DavidCorral94
Copy link

Hey there!

We are using the Apache Pekko Connectors Google Cloud Pub Sub in our project to consume messages from PubSub and we have noticed the following weird scenario.

These are the available method to subscribe to a PubSub topic and receive data from them, as you can see, both methods expect a PubSubConfig as settings.

But then, in the PubSubConfig class, I get a deprecation warning when creating an instance of this type telling me that I should be using a GoogleSettings to manage credentials. That sounds reasenable, but if I use that as my settings, I can't provide it to any of the subscribe methods listed above.

What then should I do? Is there any mapping/transformation available between PubSubConfig and GoogleSettings?

Thanks!

@raboof
Copy link
Member

raboof commented Sep 18, 2024

It seems it's not the whole PubSubConfig class that is deprecated, but just the apply method that also takes a projectId.

I agree it's not super clear where those GoogleSettings should be coming from - from https://pekko.apache.org/docs/pekko-connectors/current/google-common.html#credentials I get the impression that you can provide them 'indirectly' as documented there?

@DavidCorral94
Copy link
Author

@raboof thanks for answering. Worth to try, I'll report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants