-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOR shardingsphere5.3 dynamic config suggestion #24498
Comments
is anyone can help me? |
@hyz1994121 You can look this : #23388 |
by the way, i found in 5.3.0 , i must use HikariDataSource for sharding.yaml, i wonder know if i can use the alibaba.druid for my DataSource. Becuase the druid provid some monitor for the db connection |
I also encountered this issue when using nacos. sharding.yaml cannot reference the values of the configuration files in nacos |
+1 |
Yes, the main issue is that there is still no smooth transition plan, but fortunately, SPI was provided. I implemented the configuration loading of NACOS myself and also replaced the values referenced by Spring's ${} |
@liming0 Can you contribute your implement to upstream to help more users? |
The Nacos implementation comes from some community contributors, so it is not perfect now, and we hope that more developers will improve it so that it has a chance to become more stable. |
Yes, I have removed the part about spring from my code. How can I contribute the code next |
Hi @liming0, you can submit a new issue to describe your modify, and then we could discuss in this issue. |
|
In my project i try upgrade shardingsphere from 5.1.1 to 5.3
i use shardingshpere jdbc by spring-namespace
after read this, https://community.sphere-ex.com/t/topic/1284 finished my upgrade
then i found some problem, in sharding.yaml i must use the real jdbcurl for datasource config
before, in my project ,we use ${jdbc.url} by apollo config to distinguish different environment,ex qa, ol
i found to build spring bean org.springframework.jdbc.datasource.SimpleDriverDataSource , i could set username, password by apollo config, but the url must use jdbc:shardingsphere:classpath:sharding.yaml like this,
to use prefix jdbc:shardingsphere:
though i could not use the dynamic config to distinguish the different enviroment.
in different env i must make 2 yaml file, it's very uncomfortable.
The text was updated successfully, but these errors were encountered: