Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] nacos-client lib has a security vulnerability #9559

Closed
2 of 3 tasks
pjfanning opened this issue Sep 3, 2022 · 5 comments
Closed
2 of 3 tasks

[Bug] nacos-client lib has a security vulnerability #9559

pjfanning opened this issue Sep 3, 2022 · 5 comments
Labels
bug Something isn't working and you are sure it's a bug! dependencies Pull requests that update a dependency file ecosystem Things related to SkyWalking, but codes hosting in 3rd-party rejected The issue or PR can't be accepted by upstream.
Milestone

Comments

@pjfanning
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

Apache SkyWalking Component

OAP server (apache/skywalking)

What happened

nacos-client lib has a security vulnerability

GHSA-2g86-r6w2-wqqr

v2.0.3 or later is needed

What you expected to happen

ideally, no insecure libs should be used

How to reproduce

use a code scanner - like dependabot

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@pjfanning pjfanning added the bug Something isn't working and you are sure it's a bug! label Sep 3, 2022
@wu-sheng
Copy link
Member

wu-sheng commented Sep 3, 2022

Welcome to submit a pull request to update with updating versions in license using skywalking-eyes tool

@wu-sheng wu-sheng added the dependencies Pull requests that update a dependency file label Sep 3, 2022
@wu-sheng wu-sheng added this to the 9.3.0 milestone Sep 3, 2022
@kezhenxu94
Copy link
Member

I tried to fix this in #9545 and found we are using 1.x but they fix this in 2.x. Also, they started to package all dependency by shading into their client SDK so the package becomes really large, what's more, the dependencies that are packed into the SDK also have CVE, so we have literally NO way to upgrade them.

In all, we have no way to upgrade to a version without CVE for Nacos.

Do you use nacos or only because it exists to cause CVE? If it's latter you can just remove the related jars out of your environment.

We have to consider removing nacos related things one day if it becomes unmaintainable like this.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 4, 2022

We have to consider removing nacos related things one day if it becomes unmaintainable like this.

I think we need to submit an issue to nacos as a warning and suggestion.
I agree that providing a uber jar is not a good practice for a library.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 5, 2022

I submitted one to Nacos, alibaba/nacos#9091

Let's see how they reply from official team.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2022

According to the official response, alibaba/nacos#9091 (comment), this is not a CVE we need to concern.

@wu-sheng wu-sheng closed this as completed Sep 6, 2022
@wu-sheng wu-sheng added rejected The issue or PR can't be accepted by upstream. ecosystem Things related to SkyWalking, but codes hosting in 3rd-party labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug! dependencies Pull requests that update a dependency file ecosystem Things related to SkyWalking, but codes hosting in 3rd-party rejected The issue or PR can't be accepted by upstream.
Projects
None yet
Development

No branches or pull requests

3 participants