Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than 100 roles will cause RLS role dropdown and API not showing all roles #31466

Open
3 tasks done
ziggekatten opened this issue Dec 16, 2024 · 3 comments
Open
3 tasks done
Labels
authentication:row-level-security Related to Row Level Security

Comments

@ziggekatten
Copy link

Bug description

As per discussion: #31439

There seems to be an hard limit on number of roles returned in API as well as the dropdown in Row Level Security form

I have tried to find this in the code, but with no luck

Screenshots/recordings

No response

Superset version

4.0.2

Python version

3.10

Node version

I don't know

Browser

Chrome

Additional context

I'm using official docker image

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added the authentication:row-level-security Related to Row Level Security label Dec 16, 2024
Copy link

dosubot bot commented Dec 16, 2024

I found a similar unsolved discussion titled "RLS do not show all roles in dropdown" on GitHub, which might be related to the issue you're experiencing [1].

Regarding the issue of a hard limit on the number of roles returned by the API and displayed in the dropdown, it seems that the AsyncSelect component is involved in fetching roles. This component uses pagination parameters such as page and pageSize, with a default pageSize of 10 [2]. However, there is no specific information available about a hard limit of 100 roles in the backend or in the superset_config.py file.

To address this issue, you might want to investigate the backend code handling the /api/v1/rowlevelsecurity/related/roles endpoint for any pagination logic or limits. Additionally, reviewing the superset_config.py file for any settings related to API pagination or limits could be helpful, although no specific settings were found in the available information.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@rusackas
Copy link
Member

That's a lot of roles! I don't doubt the bug, but I'm curious the use case. I also see you opened a discussion as well... can we close one or the other so there's not a duplicate conversation?

@ziggekatten
Copy link
Author

Very simple use case: 200+ contracts with varying data sources as well as shared data sources (hence the RLS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication:row-level-security Related to Row Level Security
Projects
None yet
Development

No branches or pull requests

2 participants