Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pages work without JavaScript #98

Open
sebbASF opened this issue Sep 9, 2021 · 8 comments
Open

Ensure pages work without JavaScript #98

sebbASF opened this issue Sep 9, 2021 · 8 comments
Assignees
Labels
being worked on Improvements are in process

Comments

@sebbASF
Copy link
Contributor

sebbASF commented Sep 9, 2021

As the subject says: all pages should work without needing JavaScript.
For example by providing alternate content within tags.

Pages that contain <script but don't contain <noscript are:

foundation/bylaws_2021_diff.html
foundation/contributing-v5.md
foundation/contributing.md
foundation/donated.md
foundation/marks/contact.md
foundation/marks/index.md
foundation/press/kit/index.md
foundation/thanks.md
history/directors.md
index.ezmd
info/how-to-mirror.md

Not all of these may need fixing

@cottage14 cottage14 self-assigned this Sep 9, 2021
@cottage14 cottage14 added the being worked on Improvements are in process label Sep 9, 2021
@cottage14
Copy link
Contributor

I have added tags to each of the listed pages.

@sebbASF sebbASF reopened this Sep 9, 2021
@sebbASF
Copy link
Contributor Author

sebbASF commented Sep 9, 2021

Sorry, but merely adding a standard noscript banner is not a valid solution.
The noscript text needs to be adapted for each page.

For example, the change to the info/how-to-mirror page has broken it; there is now no link for non-JS browsers.

Also the change to bylaws_2021_diff.html is misleading, as the only loss to non-JS uses is not being able to navigate between changes by pressing n and p. The page is otherwise fine.

I've not checked the other pages yet.

@cottage14
Copy link
Contributor

how-to-mirror.md no longer needs a link for non-JS browsers. There is a statement on the page now that we are no longer accepting mirror requests.

@sebbASF
Copy link
Contributor Author

sebbASF commented Sep 9, 2021

If it does not need to redirect for non-JS browsers, why does it redirect if JS is available?
JS should be used to enhance pages, not discriminate against non-JS users

@cottage14
Copy link
Contributor

I agree. So the JS is now gone from that page.

@sebbASF
Copy link
Contributor Author

sebbASF commented Sep 9, 2021

I'm not sure that is the right fix.

@sebbASF
Copy link
Contributor Author

sebbASF commented Sep 9, 2021

Other issues:

@sebbASF
Copy link
Contributor Author

sebbASF commented Sep 9, 2021

It's not trivial fixing these pages, but we should at least try to minimise the effect on non-JS browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
being worked on Improvements are in process
Projects
None yet
Development

No branches or pull requests

2 participants