Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor finder #2

Open
gillesdemey opened this issue Dec 3, 2014 · 0 comments
Open

Refactor finder #2

gillesdemey opened this issue Dec 3, 2014 · 0 comments

Comments

@gillesdemey
Copy link
Member

Right now, the finder is pretty useless.

We need to refactor it so it can take multiple finders, each finder designated to deal with a certain icon type.

This means we need the following finders:

  • Opengraph
  • Twitter
  • Schema.org
  • Apple
  • Favicon

Each of them deal with fetching icons in their own way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant