Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify protocol contracts on block explorers #1630

Closed
1 of 5 tasks
Ashar2shahid opened this issue Jan 31, 2023 · 6 comments
Closed
1 of 5 tasks

Verify protocol contracts on block explorers #1630

Ashar2shahid opened this issue Jan 31, 2023 · 6 comments

Comments

@Ashar2shahid
Copy link
Contributor

Ashar2shahid commented Jan 31, 2023

The following chains do not have the protocol contracts verified on their block-explorers due to technical issues (block explorer being decommissioned, verification api failing etc). When the issues are resolved, the contracts have to verified on the explorer

aurora and aurora-testnet:
Etherscan discontinued from 1st Feb. They are migrating to blockscout but their blockscout doesn't support verification at the moment.

sx-network and sx-network-testnet:
Not sure why verification is failing, have to check with their team

godwoken-testnet:
Not sure why verification is failing, have to check with their team

@bbenligiray
Copy link
Member

Note to @aTeoke, this is blocked externally so don't add it to milestones

@bbenligiray
Copy link
Member

Our current protocol is that if the contract verification API of the main block explorer of a chain doesn't work, we don't verify. These are documented to a degree on the https://github.com/api3dao/chains README.

@dcroote
Copy link
Contributor

dcroote commented Sep 19, 2023

Does our opinion change if we're unable to verify via the API, but are able to via the web interface? Example: I was just able to verify AirnodeRrpV0 on Aurora: https://explorer.mainnet.aurora.dev/address/0xE338f63170c42bA0d2a888f18F6185369779009c/contracts#address-tabs

@bbenligiray
Copy link
Member

The graphical interface works in a lot of cases where the API doesn't. However, that creates so much additional workload that we can't feasibly do this for all chains (or we can, but I'd rather we didn't).

@dcroote
Copy link
Contributor

dcroote commented Sep 21, 2023

I played just a couple of minutes more on web interfaces- the aurora-testnet verification hung endlessly and the sx compiler dropdown was broken (there just weren't any compiler options), so yeah, I agree.

@bbenligiray
Copy link
Member

I guess this means that this issues can be closed

As a note, I want to check if a block explorer API is working at @api3/chains (and omit the API info if it doesn't work) so the deployment script here automatically knows if we need verification or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants