Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports flags to chains #3

Closed
bbenligiray opened this issue Apr 12, 2023 · 5 comments
Closed

Add supports flags to chains #3

bbenligiray opened this issue Apr 12, 2023 · 5 comments

Comments

@bbenligiray
Copy link
Member

Currently, the common property of all chains in @api3/chains is that Api3ServerV1 is deployed on them. However, we now need to add chains that Api3ServerV1 is not necessarily deployed on, which will create confusion about which chains are supported for what. On top of that, ChainAPI supports an entirely independent subset of all these chains.

I propose that we add a supports field to the chain object as in

{
  "supports": [ "AirnodeRrpV0", "Api3ServerV1", "ChainAPI" ],
  ...
}

@andreogle wdyt?

@andreogle
Copy link
Member

Yeah sounds good to me. I can't think of a better structure for this at the moment.

I'm hoping to get the TypeScript PR merged either today or tomorrow, but feel free to add this to current main if it's urgent and I'll merge those changes into that PR

@bbenligiray
Copy link
Member Author

Okay, I'm planning to review the PR tomorrow and we can do this after that is merged

@bbenligiray bbenligiray changed the title Add support flags to chains Add supports flags to chains Apr 15, 2023
@bbenligiray
Copy link
Member Author

As a note, I'm currently doing this partially here https://github.com/api3dao/airnode-protocol-v1/blob/main/src/supported-chains.js

@andreogle
Copy link
Member

Nice, thanks. I can work on adding this later using that list as the reference

@andreogle
Copy link
Member

Closing this issue. See related (closed) PR for more info: #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants