Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PHP implementation to Skillshare library #442

Open
2 tasks
rvanlaak opened this issue Jun 1, 2023 · 0 comments
Open
2 tasks

Rename PHP implementation to Skillshare library #442

rvanlaak opened this issue Jun 1, 2023 · 0 comments

Comments

@rvanlaak
Copy link

rvanlaak commented Jun 1, 2023

When looking at the code related to the /implementation/php, it seems that this isn't testing PHP, but that according to the composer.json the skillshare/apollo-federation-php library is being tested. This leads to unclarity.

In addition, I've assessed all of the PHP libraries on https://graphql.org/code/#php, and it seems that the majority of them is an extension to the webonyx/graphql-php library. Maybe we can add a test suite which solely tests the webonyx library?

TODO

  • add test coverage on webonyx/graphql-php implementation
  • rename the /implementation/php to /implementation/php-skillshare/apollo-federation-php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant