From fac4ad65be5b4bc00ab5e06510e73a6fdedf9c16 Mon Sep 17 00:00:00 2001 From: Liz Hennessy Date: Thu, 6 Jul 2023 13:12:37 -0600 Subject: [PATCH] fix tests --- client/src/components/__tests__/module-detail.js | 4 ++-- client/src/components/__tests__/modules-navigation.js | 4 ++-- client/src/components/__tests__/track-detail.js | 4 ++-- client/src/containers/__tests__/track-card.js | 4 ++-- client/src/utils/test-utils.js | 9 +++++++++ final/client/src/components/__tests__/module-detail.js | 4 ++-- .../src/components/__tests__/modules-navigation.js | 4 ++-- final/client/src/components/__tests__/track-detail.js | 4 ++-- final/client/src/containers/__tests__/track-card.js | 4 ++-- final/client/src/utils/test-utils.js | 9 +++++++++ 10 files changed, 34 insertions(+), 16 deletions(-) diff --git a/client/src/components/__tests__/module-detail.js b/client/src/components/__tests__/module-detail.js index 1c7e083cc..6c1422cc9 100644 --- a/client/src/components/__tests__/module-detail.js +++ b/client/src/components/__tests__/module-detail.js @@ -1,5 +1,5 @@ import React from 'react'; -import { render, cleanup } from '../../utils/test-utils'; +import { renderWithRouter, cleanup } from '../../utils/test-utils'; import ModuleDetail from '../module-detail'; const mockModule = { @@ -41,6 +41,6 @@ describe('Module Detail View', () => { afterEach(cleanup); it('renders without error', () => { - render(); + renderWithRouter(); }); }); diff --git a/client/src/components/__tests__/modules-navigation.js b/client/src/components/__tests__/modules-navigation.js index b501622aa..f7d0c2e28 100644 --- a/client/src/components/__tests__/modules-navigation.js +++ b/client/src/components/__tests__/modules-navigation.js @@ -1,5 +1,5 @@ import React from 'react'; -import { render, cleanup } from '../../utils/test-utils'; +import { renderWithRouter, cleanup } from '../../utils/test-utils'; import ModuleNav from '../modules-navigation'; const mockModule = { @@ -41,6 +41,6 @@ describe('Modules Navigation View', () => { afterEach(cleanup); it('renders without error', () => { - render(); + renderWithRouter(); }); }); diff --git a/client/src/components/__tests__/track-detail.js b/client/src/components/__tests__/track-detail.js index ad3c62a23..86f84542b 100644 --- a/client/src/components/__tests__/track-detail.js +++ b/client/src/components/__tests__/track-detail.js @@ -1,5 +1,5 @@ import React from 'react'; -import { render, cleanup } from '../../utils/test-utils'; +import { renderWithRouter, cleanup } from '../../utils/test-utils'; import TrackDetail from '../track-detail'; const mockTrack = { @@ -32,6 +32,6 @@ describe('Module Detail View', () => { afterEach(cleanup); it('renders without error', () => { - render(); + renderWithRouter(); }); }); diff --git a/client/src/containers/__tests__/track-card.js b/client/src/containers/__tests__/track-card.js index a1378d120..39c5ff2cb 100644 --- a/client/src/containers/__tests__/track-card.js +++ b/client/src/containers/__tests__/track-card.js @@ -1,5 +1,5 @@ import React from 'react'; -import { renderApollo, cleanup, waitForElement } from '../../utils/test-utils'; +import { renderApolloWithRouter, cleanup, waitForElement } from '../../utils/test-utils'; import TrackCard from '../track-card'; const mockTrackCardData = { @@ -21,7 +21,7 @@ describe('Track Card', () => { it('renders track Card', async () => { const mocks = []; - const { getByText } = await renderApollo( + const { getByText } = await renderApolloWithRouter( , { mocks, diff --git a/client/src/utils/test-utils.js b/client/src/utils/test-utils.js index a8c0b45d0..bd30f4323 100644 --- a/client/src/utils/test-utils.js +++ b/client/src/utils/test-utils.js @@ -1,5 +1,6 @@ import React from 'react'; import { render } from '@testing-library/react'; +import { BrowserRouter } from 'react-router-dom' import '@testing-library/jest-dom/extend-expect'; import { MockedProvider } from '@apollo/client/testing'; @@ -22,5 +23,13 @@ const renderApollo = ( ); }; +export const renderWithRouterGenerator = (renderer) => (node, options) => { + return renderer({node}, options) +} + +export const renderWithRouter = renderWithRouterGenerator(render) + +export const renderApolloWithRouter = renderWithRouterGenerator(renderApollo) + export * from '@testing-library/react'; export { renderApollo }; diff --git a/final/client/src/components/__tests__/module-detail.js b/final/client/src/components/__tests__/module-detail.js index 1c7e083cc..6c1422cc9 100644 --- a/final/client/src/components/__tests__/module-detail.js +++ b/final/client/src/components/__tests__/module-detail.js @@ -1,5 +1,5 @@ import React from 'react'; -import { render, cleanup } from '../../utils/test-utils'; +import { renderWithRouter, cleanup } from '../../utils/test-utils'; import ModuleDetail from '../module-detail'; const mockModule = { @@ -41,6 +41,6 @@ describe('Module Detail View', () => { afterEach(cleanup); it('renders without error', () => { - render(); + renderWithRouter(); }); }); diff --git a/final/client/src/components/__tests__/modules-navigation.js b/final/client/src/components/__tests__/modules-navigation.js index b501622aa..f7d0c2e28 100644 --- a/final/client/src/components/__tests__/modules-navigation.js +++ b/final/client/src/components/__tests__/modules-navigation.js @@ -1,5 +1,5 @@ import React from 'react'; -import { render, cleanup } from '../../utils/test-utils'; +import { renderWithRouter, cleanup } from '../../utils/test-utils'; import ModuleNav from '../modules-navigation'; const mockModule = { @@ -41,6 +41,6 @@ describe('Modules Navigation View', () => { afterEach(cleanup); it('renders without error', () => { - render(); + renderWithRouter(); }); }); diff --git a/final/client/src/components/__tests__/track-detail.js b/final/client/src/components/__tests__/track-detail.js index ad3c62a23..86f84542b 100644 --- a/final/client/src/components/__tests__/track-detail.js +++ b/final/client/src/components/__tests__/track-detail.js @@ -1,5 +1,5 @@ import React from 'react'; -import { render, cleanup } from '../../utils/test-utils'; +import { renderWithRouter, cleanup } from '../../utils/test-utils'; import TrackDetail from '../track-detail'; const mockTrack = { @@ -32,6 +32,6 @@ describe('Module Detail View', () => { afterEach(cleanup); it('renders without error', () => { - render(); + renderWithRouter(); }); }); diff --git a/final/client/src/containers/__tests__/track-card.js b/final/client/src/containers/__tests__/track-card.js index a1378d120..39c5ff2cb 100644 --- a/final/client/src/containers/__tests__/track-card.js +++ b/final/client/src/containers/__tests__/track-card.js @@ -1,5 +1,5 @@ import React from 'react'; -import { renderApollo, cleanup, waitForElement } from '../../utils/test-utils'; +import { renderApolloWithRouter, cleanup, waitForElement } from '../../utils/test-utils'; import TrackCard from '../track-card'; const mockTrackCardData = { @@ -21,7 +21,7 @@ describe('Track Card', () => { it('renders track Card', async () => { const mocks = []; - const { getByText } = await renderApollo( + const { getByText } = await renderApolloWithRouter( , { mocks, diff --git a/final/client/src/utils/test-utils.js b/final/client/src/utils/test-utils.js index a8c0b45d0..bd30f4323 100644 --- a/final/client/src/utils/test-utils.js +++ b/final/client/src/utils/test-utils.js @@ -1,5 +1,6 @@ import React from 'react'; import { render } from '@testing-library/react'; +import { BrowserRouter } from 'react-router-dom' import '@testing-library/jest-dom/extend-expect'; import { MockedProvider } from '@apollo/client/testing'; @@ -22,5 +23,13 @@ const renderApollo = ( ); }; +export const renderWithRouterGenerator = (renderer) => (node, options) => { + return renderer({node}, options) +} + +export const renderWithRouter = renderWithRouterGenerator(render) + +export const renderApolloWithRouter = renderWithRouterGenerator(renderApollo) + export * from '@testing-library/react'; export { renderApollo };