Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Paths in http proxy #720

Open
rohan-datar opened this issue Oct 21, 2024 · 1 comment
Open

Allow Paths in http proxy #720

rohan-datar opened this issue Oct 21, 2024 · 1 comment

Comments

@rohan-datar
Copy link

rohan-datar commented Oct 21, 2024

Currently, http proxies for only support a http://<host>:<port> scheme.
From the docs:

When specifying a proxy address, it must have scheme http, and may not contain anything other than a host and port.

Trying to proxy pkl packages through something like Artifactory Remote Repositories does not work as they add a path to the proxy url which is not supported and throws a Java exception when it attempts to resolve.

Allowing proxies to have a http://<host>:<port>/path/to/proxy would be very helpful

@HT154
Copy link
Contributor

HT154 commented Oct 21, 2024

Pkl's HTTP proxy support is for CONNECT-based HTTP forward proxies. These work very differently from something like an Artifactory remote repo, which is a read-through caching reverse proxy.

Supporting mirroring via such a reverse proxy requires some additional handling and is being discussed in SPICE-0002.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants