Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Azure credentials via environment variables #1027

Open
AlbertoGarciaFdez opened this issue Feb 9, 2022 · 2 comments
Open
Assignees

Comments

@AlbertoGarciaFdez
Copy link

Hi, I noticed that while AWS credentials can be injected via env vars (AWS_SECRET_ACCESS_KEY AWS_ACCESS_KEY_ID) for azure, credentials are only taken from environment for tests and making use of env vars for actual usage is missing ( AZURE_STORAGE_ACCOUNT AZURE_STORAGE_ACCESS_KEY).

Is there a reason to avoid using AZURE_STORAGE_ACCOUNT and AZURE_STORAGE_ACCESS_KEY env vars for azure? I find way more convenient using environment vars for credentials instead of adding them to the json config file.

IMHO using env vars can ease sharing config while keeping a low exposure for credentials, delegating variable injection to tooling focused on credentials management.

@chuan
Copy link
Contributor

chuan commented Apr 29, 2022

@AlbertoGarciaFdez The AWS credentials feature is provided by AWS SDK not Aptly. The Azure blob Go SDK (https://github.com/Azure/azure-storage-blob-go) we depend on does not provide such functionalities. At the time Azure publish was implemented, that was the only option available. The latest Azure blob SDK supports the feature you want, but it requires Go 1.8 while Aptly right now wants to be compatible with Go 1.5. You will likely get the feature automatically in the future after the Go version and blob SDK are updated in Aply.

@lubo
Copy link

lubo commented May 16, 2024

Could solving #1290 help here?

@neolynx neolynx self-assigned this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants