fix(misconf): properly expand dynamic blocks #7612
Open
+402
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <[email protected]>
6 tasks
Signed-off-by: nikpivkin <[email protected]>
nikpivkin
commented
Oct 7, 2024
| @@ -567,7 +567,7 @@ resource "something" "else" { | |||
| for_each = toset(["true"]) | |||
|
|
|||
| content { | |||
| ok = each.value | |||
| ok = blah.value | |||
There was a problem hiding this comment.
For reviewers: this test should not have run successfully because dynamic blocks do not create an each object.
simar7
reviewed
Oct 17, 2024
| expected: []any{"ssh", "http", "https"}, | ||
| }, | ||
| { | ||
| name: "map key", |
There was a problem hiding this comment.
can we rename the case accordingly?
simar7
reviewed
Oct 17, 2024
| } | ||
| } | ||
| }`, | ||
| }, |
There was a problem hiding this comment.
maybe add an explicit expected block with the nil value or a comment to explain it so we don't think it's been missed by mistake.
simar7
reviewed
Oct 17, 2024
|
|
||
| realBlockType := b.TypeLabel() | ||
| if realBlockType == "" { | ||
| return nil, errors.New("dynamic block must have 1 label") |
There was a problem hiding this comment.
we seem to have been using fmt.Errorf elsewhere, should we stick to it?
There was a problem hiding this comment.
fmt.Errorf is used to format the string
simar7
reviewed
Oct 17, 2024
| return expanded, errors.Join(errs...) | ||
| } | ||
|
|
||
| func (b *Block) validateForEach() (cty.Value, error) { |
There was a problem hiding this comment.
Can we add test cases for the error paths in this func?
There was a problem hiding this comment.
This test covers those cases
Signed-off-by: nikpivkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates the logic for expanding dynamic blocks from expanding the
for-eachmeta argument.Related issues
Checklist