Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid repo_depends #1414

Closed
11 of 12 tasks
yan12125 opened this issue Dec 2, 2019 · 8 comments
Closed
11 of 12 tasks

Invalid repo_depends #1414

yan12125 opened this issue Dec 2, 2019 · 8 comments
Assignees

Comments

@yan12125
Copy link
Member

yan12125 commented Dec 2, 2019

问题类型 / Type of issues

  • 打包错误 / packaging error

受影响的软件包 / Affected packages


Following-up of #1351 (comment).

Some packages have non-existent or unmanaged pkgbase in repo_depends. For example, libgnomeui depends on non-existent gnome-vfs-nosmb, and archcn-tools-meta depends on unmanaged lilacinfo.

Here is the full list.

mycli depends on python-pymysql, which does not exist or is unmanaged
jekyll depends on ruby-i18n, which does not exist or is unmanaged
fs-uae-arcade-devel depends on python-lhafile, which does not exist or is unmanaged
lib32-qt4 depends on lib32-libmng, which does not exist or is unmanaged
libsolv depends on rpm-org, which does not exist or is unmanaged

The list is generated from the following script:

import pathlib
import sys

sys.path.append('vendor')

from lilac2.lilacpy import load_managed

mods, errors = load_managed(pathlib.Path('../repo/archlinuxcn').resolve())
assert not errors
for name, mod in mods.items():
    for dep in getattr(mod, 'repo_depends', []):
        if isinstance(dep, tuple):
            pkgbase = dep[0]
        else:
            pkgbase = dep
        if pkgbase not in mods:
            print(f'{name} depends on {pkgbase}, which does not exist or is unmanaged')

Such problems might need to be checked periodically archlinuxcn/misc_scripts#2.

@farseerfc
Copy link
Member

Changed archcn-tools-meta to managed: false

a-wing added a commit that referenced this issue Dec 2, 2019
SilverRainZ added a commit that referenced this issue Dec 4, 2019
@SilverRainZ SilverRainZ removed their assignment Dec 4, 2019
@VOID001 VOID001 removed their assignment Dec 15, 2019
@yan12125
Copy link
Member Author

I ran the script again and updated the list.

@SilverRainZ
Copy link
Member

jekyll has been fixed.

@SilverRainZ SilverRainZ removed their assignment Jan 14, 2020
@Sasasu Sasasu removed their assignment Jan 27, 2020
Sasasu pushed a commit that referenced this issue Jan 27, 2020
@yan12125
Copy link
Member Author

yan12125 commented Apr 4, 2020

@hubutui Since the removal of mxnet (#1513), repo_depends entries in the following packages are no longer valid: python-onnx, python-mxboard, python-gluoncv.

@hubutui
Copy link
Contributor

hubutui commented Apr 5, 2020

@yan12125 But mxnet-git provides mxnet. Do I need to add the specific pkgname in repo_depends ?

@lilydjwg
Copy link
Member

lilydjwg commented Apr 5, 2020

@hubutui repo_depends specifies what packages from this repo you need to install. So yes.

hubutui added a commit that referenced this issue Apr 5, 2020
@yan12125
Copy link
Member Author

yan12125 commented Apr 6, 2020

In remaining packages, fs-uae-arcade-devel and libsolv depends on official packages that are once in this repo, and both should be easy to fix. lib32-qt4 depends on lib32-libmng, which was removed during 2019 cleanup (#1081). @heavysink Could you fix or drop lib32-qt4?

@farseerfc farseerfc removed their assignment Apr 8, 2020
heavysink added a commit that referenced this issue Apr 9, 2020
@heavysink
Copy link
Contributor

In remaining packages, fs-uae-arcade-devel and libsolv depends on official packages that are once in this repo, and both should be easy to fix. lib32-qt4 depends on lib32-libmng, which was removed during 2019 cleanup (#1081). @heavysink Could you fix or drop lib32-qt4?

I have added lib32-libmng as the dependency of lib32-qt4

lilydjwg added a commit that referenced this issue Jun 25, 2020
Test for invalid repo_depends items (closes #1414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants