Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possbile error in LSM6DS3.cpp #7

Open
Alberto-SM opened this issue Jan 23, 2020 · 2 comments · Fixed by #8
Open

Possbile error in LSM6DS3.cpp #7

Alberto-SM opened this issue Jan 23, 2020 · 2 comments · Fixed by #8
Assignees
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@Alberto-SM
Copy link

I'm afraid that these lines in LSM6DS3.cpp are not correct:

93 // Set the ODR config register to ODR/4
94 writeRegister(LSM6DS3_CTRL8_XL, 0x09);

Actually, ODRs are set in CTRL1_XL and CTRL2_G.
I discovered this beacuse that line was making not possible to set up the High Pass filter.

@Rocketct
Copy link
Contributor

Hi @Alberto-SM i checked this is a legacy of our LSM6DSM library, checking the Figure 6. Accelerometer composite filter, this line have only the effect of enable the LOW_PASS_ON_6D and setting to 1 a bit that should be set to 0 because reserved, i'll remove because added only for redundancy in the other library and here don't make sense to exist.

@per1234
Copy link
Contributor

per1234 commented Aug 22, 2022

@Rocketct the lines in question are still there:

// Set the ODR config register to ODR/4
writeRegister(LSM6DS3_CTRL8_XL, 0x09);

I see you merged the pull request which was stated as resolving this, but that pull request contained 0 commits at the time it was merged, so it had no effect on the repository:

https://github.com/arduino-libraries/Arduino_LSM6DS3/pull/8/files

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants