Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable method returns text encoding instead of json #41

Open
fredhsu opened this issue Jul 15, 2020 · 3 comments
Open

Enable method returns text encoding instead of json #41

fredhsu opened this issue Jul 15, 2020 · 3 comments

Comments

@fredhsu
Copy link

fredhsu commented Jul 15, 2020 •
edited
Loading

goeapi/client.go

Line 305 in 7944bce

jsonRsp, err := n.runCommands(commands, "text")

Although the documentation and variable name imply json output, the output is coded to text. Could we either expose runCommands as a public method or change the default behavior to be json encoding?
@cheynearista
Copy link
Contributor

@fredhsu Good points. Let me fix that.

cheynearista added a commit that referenced this issue Jul 21, 2020
@cheynearista
Issue #41
d154dfa 
* Make runCommands public
* Update variable names in Enable() to be inline with what's returned in
the rsp
@gavmckee80
Copy link

@cheynearista is this change merged yet ? I installed the lib today

jsonRsp, err := n.runCommands(commands, "text")

I still see this and need the output in JSON format

@cheynearista
Copy link
Contributor

Apologies. I merged it into develop...but had yet to do for master. It should be there on the v0.4.0 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredhsu @cheynearista @gavmckee80