Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Enhancement: Pull ClamAV defaults out into .env file for ease of configuration #38

Closed
ross-spencer opened this issue Jan 26, 2018 · 2 comments
Closed

Enhancement: Pull ClamAV defaults out into .env file for ease of configuration #38

ross-spencer opened this issue Jan 26, 2018 · 2 comments
Assignees
@ross-spencer
Labels
Type: enhancement An improvement to existing functionality. Type: good first issue An issue that would be easy for someone who has not worked with the codebase/docs before.
Milestone
1.7.0

Comments

@ross-spencer
Copy link
Contributor

ross-spencer commented Jan 26, 2018 •
edited
Loading

Currently some of the environment variables for this container sit inside a .env file and some sit inside the .yml file. For config it will be easier if they sit inside the .env.

A good template might be the JISC example: https://github.com/JiscRDSS/rdss-archivematica/blob/master/compose/.env

This ticket should also take care of variable renaming, e.g. https://github.com/artefactual/archivematica/blob/stable/1.7.x/src/MCPClient/lib/clientScripts/archivematicaClamscan.py#L103 PASS_BY_REFERENCE can become STREAM,
@ross-spencer ross-spencer self-assigned this Jan 26, 2018
@ross-spencer ross-spencer added Type: good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: enhancement An improvement to existing functionality. labels Jan 26, 2018
@ross-spencer ross-spencer added this to the v1.7.0 milestone Jan 26, 2018
qubot pushed a commit to artefactual/archivematica that referenced this issue Jan 30, 2018
@ross-spencer
Corrects negation of environment variable
f425da3 
* Corrects the negation of PASS BY REFERENCE mistakenly added to code
* Partly resolves artefactual-labs/am#38
qubot pushed a commit to artefactual/archivematica that referenced this issue Jan 31, 2018
@ross-spencer
Corrects negation of the PASS_BY_REFERENCE envvar
224cd93 
* Corrects the negation of the PASS_BY_REFERENCE envvar.
* PASS_BY_REFERENCE is not a published variable so PASS_BY_STREAM introduced.
* Partly resolves the localsed envvars issue:  artefactual-labs/am#38.
* Also addresses the issue of maximum default values: artefactual-labs/am#39.
@ross-spencer ross-spencer mentioned this issue Jan 31, 2018
Closed
qubot pushed a commit to artefactual/archivematica that referenced this issue Jan 31, 2018
@ross-spencer
Corrects negation of the PASS_BY_REFERENCE envvar
7cc3977 
* Corrects the negation of the PASS_BY_REFERENCE envvar.
* PASS_BY_REFERENCE is not a published variable so PASS_BY_STREAM introduced.
* Partly resolves the localsed envvars issue:  artefactual-labs/am#38.
* Also addresses the issue of maximum default values: artefactual-labs/am#39.
qubot pushed a commit to artefactual/archivematica that referenced this issue Jan 31, 2018
@ross-spencer
Corrects negation of the PASS_BY_REFERENCE envvar
3044b68 
* Corrects the negation of the PASS_BY_REFERENCE envvar.
* PASS_BY_REFERENCE is not a published variable so PASS_BY_STREAM introduced.
* Partly resolves the localsed envvars issue:  artefactual-labs/am#38.
* Also addresses the issue of maximum default values: artefactual-labs/am#39.
ross-spencer added a commit that referenced this issue Jan 31, 2018
@ross-spencer
Localise ClamAV defaults in .env file
c3f70ab 
* Sets defaults to their maximum values which resolves #39.
* Extracts default values into .env file per which resolves #38.
* Renames PASS_BY_REFERENCE to PASS_BY_STREAM for cleaner code in AM base.
@ross-spencer ross-spencer mentioned this issue Jan 31, 2018
Merged
qubot pushed a commit to artefactual/archivematica that referenced this issue Feb 1, 2018
@ross-spencer
Corrects negation of the PASS_BY_REFERENCE envvar
543c5e3 
* Corrects the negation of the PASS_BY_REFERENCE envvar.
* PASS_BY_REFERENCE is not a published variable so PASS_BY_STREAM introduced.
* Partly resolves the localsed envvars issue:  artefactual-labs/am#38.
* Also addresses the issue of maximum default values: artefactual-labs/am#39.
qubot pushed a commit to artefactual/archivematica that referenced this issue Feb 2, 2018
@ross-spencer
Corrects negation of the PASS_BY_REFERENCE envvar
dbf8176 
* Corrects the negation of the PASS_BY_REFERENCE envvar.
* PASS_BY_REFERENCE is not a published variable so PASS_BY_STREAM introduced.
* Partly resolves the localsed envvars issue:  artefactual-labs/am#38.
* Also addresses the issue of maximum default values: artefactual-labs/am#39.
qubot pushed a commit to artefactual/archivematica that referenced this issue Feb 2, 2018
@ross-spencer
Corrects negation of the PASS_BY_REFERENCE envvar
2e59a62 
* Corrects the negation of the PASS_BY_REFERENCE envvar.
* PASS_BY_REFERENCE is not a published variable so PASS_BY_STREAM introduced.
* Partly resolves the localsed envvars issue:  artefactual-labs/am#38.
* Also addresses the issue of maximum default values: artefactual-labs/am#39.
@ross-spencer
Copy link
Contributor Author

Closed by #40

@ross-spencer
Copy link
Contributor Author

Relevant to #42

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ross-spencer ross-spencer

Labels
Type: enhancement An improvement to existing functionality. Type: good first issue An issue that would be easy for someone who has not worked with the codebase/docs before.
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
1 participant
@ross-spencer