Error trying to change ownership of broken symlink

[djjuhasz]

When re-running the role after a failure, I get the following error:

TASK [external-roles/artefactual-atom : Temporarily change ownership of site directory to be able to clone repo] ***
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: OSError: [Errno 2] No such file or directory: '/usr/share/nginx/atom-uploads'
fatal: [asa-atom-test]: FAILED! => {"changed": false, "module_stderr": "Traceback (most recent call last):\n File "/tmp/ansible_SrI3Dd/ansible_module_file.py", line 473, in \n main()\n File "/tmp/ansible_SrI3Dd/ansible_module_file.py", line 350, in main\n changed |= recursive_set_attributes(module, to_bytes(file_args['path'], errors='surrogate_or_strict'), follow, file_args)\n File "/tmp/ansible_SrI3Dd/ansible_module_file.py", line 172, in recursive_set_attributes\n changed |= module.set_fs_attributes_if_different(tmp_file_args, changed, expand=False)\n File "/tmp/ansible_SrI3Dd/ansible_modlib.zip/ansible/module_utils/basic.py", line 1507, in set_fs_attributes_if_different\n File "/tmp/ansible_SrI3Dd/ansible_modlib.zip/ansible/module_utils/basic.py", line 1164, in set_owner_if_different\n File "/tmp/ansible_SrI3Dd/ansible_modlib.zip/ansible/module_utils/basic.py", line 1059, in user_and_group\nOSError: [Errno 2] No such file or directory: '/usr/share/nginx/atom-uploads'\n", "module_stdout": "", "msg": "MODULE FAILURE", "rc": 1}

The error is due to the atom-uploads symlink being broken (links to a non-existent directory) and a change in how the "recurse" functionality works in ansible 2.5.1+, See: ansible issue #39456

[djjuhasz]

I wonder if we should create the atom_uploads_symlink directory if it doesn't exist?

[djjuhasz]

Probably we just want to use follow: no when changing permissions. I don't think we need to change permissions of symlinked dirs.

[mamedin]

@djjuhasz I'm working on a PR to add some features we are still using with the AtoM multisite deploy playbook.

WIP branch: https://github.com/artefactual-labs/ansible-atom/tree/dev/add-revision-dir

I added a task to create the atom_uploads_symlink and atom_downloads_symlink directories.

[djjuhasz]

Hi Miguel, It would be helpful to me to know what I can do to best support your work at this point. Are you asking for feedback on your work so far, or are you just letting me know that you are working on it? If you would like feedback, the easiest way for me to provide feedback is if you create a WIP PR, and assign me as a reviewer. Cheers, David

…

-- David JuhaszSenior Developer Artefactual Systems <http://www.artefactual.com> he/him

On Mon, Jul 27, 2020 at 12:42 PM Miguel Angel Medinilla < ***@***.***> wrote: @djjuhasz <https://github.com/djjuhasz> I'm working on a PR to add some features we are still using with the AtoM multisite deploy playbook. WIP branch: https://github.com/artefactual-labs/ansible-atom/tree/dev/add-revision-dir I added a task to create the atom_uploads_symlink and atom_downloads_symlink directories. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEY3V52XNL7SAQKVE7ZEWTR5XKDZANCNFSM4E57NF7Q> .

[mamedin]

Thanks @djjuhasz, I was letting yo know that I was working on it. But I'll add you to the CR!