authentication fails when password contains & character

[lebeno]

Authentications fails when the username or password contains a special character like &

Probably caused because the login method of class HttpApi in aos.py does not escape username and password:

path = '/v1/api/login?username='+username+'&password='+password

Possible solution:

import urllib.parse

class HttpApi(HttpApiBase):
    def __init__(self, *args, **kwargs):
        super(HttpApi, self).__init__(*args, **kwargs)

    def login(self, username, password):
        path = '/v1/api/login?username='+urllib.parse.quote(str(username), safe='')+'&password='+urllib.parse.quote(str(password), safe='')
        method = 'GET'
        self.send_request(data=None, path=path, method=method)

[lebeno]

Pinging @jayp193 and @karthikeyan-dhandapani to please have a look at this issue and the proposed fix that URL encodes username and password in the API call.