Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Firefox, pages viewed directly from GitHub are not render properly #290

Open
twilight-sparkle-irl opened this issue Jun 10, 2019 · 4 comments

Comments

@twilight-sparkle-irl
Copy link

Examples of non-working githubusercontent files: 1 and 2

Yes, I know github renders them inline. I want to use this extension to view them because I prefer the styling and such (and either way this is a bug)

@ggrossetie
Copy link
Member

Hello @NO-BOOT-DEVICE, I guess that you are using Firefox right ?
This is actually a bug in Firefox as described in the README: https://github.com/asciidoctor/asciidoctor-browser-extension#firefox

On Firefox, pages viewed directly from GitHub may not render properly. This is result of a Firefox bug carrying over the Content Security Policies (CSP). The restrictive CSP sent by GitHub are applied to the content inserted by the WebExtension.

Here's how it looks like with Chrome:

gist2
gist1

If you want you can vote for this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1267027

@ggrossetie
Copy link
Member

@NO-BOOT-DEVICE could you please confirm that you are using Firefox ?

@twilight-sparkle-irl
Copy link
Author

Yes. Sorry for being late

@ggrossetie ggrossetie changed the title Doesn't render githubusercontent On Firefox, pages viewed directly from GitHub are not render properly Dec 9, 2019
@ggrossetie
Copy link
Member

Thanks for your input.
As mention in my comment, there's nothing we can do to workaround this bug in Firefox. The only thing we can do is vote for the issue in the Firefox bug tracker and hope it will be prioritized and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants