From ae8e7b1a1a4aff3f4273456f282a11e169a11bad Mon Sep 17 00:00:00 2001
From: Andy Maloney <asmaloney@gmail.com>
Date: Mon, 28 Aug 2023 12:52:25 -0400
Subject: [PATCH] Fix HTTP error handling to return proper error

---
 util/filesystem/filesystem.go | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/util/filesystem/filesystem.go b/util/filesystem/filesystem.go
index 9c6b043..0fc7fa1 100644
--- a/util/filesystem/filesystem.go
+++ b/util/filesystem/filesystem.go
@@ -37,6 +37,15 @@ func (e ErrExeNotFound) Error() string {
 	return fmt.Sprintf("cannot find %q in your path:\n%q", e.ExeName, e.Path)
 }
 
+type ErrHTTP struct {
+	URL        *url.URL
+	StatusCode int
+}
+
+func (e ErrHTTP) Error() string {
+	return fmt.Sprintf("server returned status code %d fetching %q", e.StatusCode, e.URL.String())
+}
+
 // DirExists returns true if the given path exists and is a directory.
 func DirExists(path string) bool {
 	stat, err := os.Stat(path)
@@ -55,11 +64,19 @@ func CreateDir(path string) (err error) {
 
 // DownloadFile downloads a file from a URL.
 func DownloadFile(url *url.URL, filePath string) (err error) {
-	resp, err := http.Get(url.String())
+	response, err := http.Get(url.String())
 	if err != nil {
 		return
 	}
-	defer resp.Body.Close()
+	defer response.Body.Close()
+
+	if response.StatusCode != http.StatusOK {
+		err = ErrHTTP{
+			URL:        url,
+			StatusCode: response.StatusCode,
+		}
+		return
+	}
 
 	out, err := os.Create(filePath)
 	if err != nil {
@@ -67,7 +84,7 @@ func DownloadFile(url *url.URL, filePath string) (err error) {
 	}
 	defer out.Close()
 
-	_, err = io.Copy(out, resp.Body)
+	_, err = io.Copy(out, response.Body)
 
 	return
 }