Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Overhead #23

Open
kalenjordan opened this issue May 23, 2013 · 4 comments
Open

Performance Overhead #23

kalenjordan opened this issue May 23, 2013 · 4 comments

Comments

@kalenjordan
Copy link

Is this expected load time overhead with caching enabled for Pulsestorm Launcher? It's almost more than doubling my page load time in the sales order grid as an example.

screen shot 2013-05-23 at 9 40 23 am

@astorm
Copy link
Owner

astorm commented May 23, 2013

Your faith that there's an expected load time is appreciated, but misplaced :)

No extra caching has been applied. The launcher uses an extended Mage_Adminhtml_Block_Page_Menu class to generate the information it uses to build the default JSON embedded in the page. If you were interested in fixing this the _renderDefaultNavigationJson method in app/code/community/Pulsestorm/Launcher/Model/Observer.php is the likely culprit, and it's return value could easily be made cached.

@kalenjordan
Copy link
Author

Awesome, thanks for the pointers. I'm hoping I'll find some time to dig into that. I've been using the module in my local for a week or so now and am starting to depend on it for quick navigation :) I'd like to roll it out to production and get the entire CST team and stuff able to use it.

@astorm
Copy link
Owner

astorm commented Jun 8, 2013

Kalen, were you able to track down the additional performance problems you saw?

@kalenjordan
Copy link
Author

No sorry! I haven't found any time to dig further into this so I haven't been using it for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants