Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

Package Next Steps #519

Closed
nstarman opened this issue Feb 3, 2022 · 9 comments
Closed

Package Next Steps #519

nstarman opened this issue Feb 3, 2022 · 9 comments

Comments

@nstarman
Copy link
Member

nstarman commented Feb 3, 2022

In today's dev telecon we discussed https://github.com/astropy/package-template/ and it's future given that there is also Python Packaging Guide. See the telecon notes (included below) for details. In brief, the suggestions are:

  1. Add a message to package_template that we are considering a move to the OA template. The message should probably be added to both the README and the cookie-cutter. See add README note about OA guide #520
  2. Recommending users to use to Python Packaging Guide while package_template is reorganized. Blocked by:
  1. Add documentation how to add Astropy infrastructure on top of Python Packaging Guide, so that affiliate packages can still make astropy-compatible packages.
  2. Funded project proposal for keeping these steps up-to-date, or ideally making a sub-branch or “astropy method” in the OA package template.

Quoting from the Dev Telecon:


Status of the astropy package template: Should it be retired in favor of Python Packaging Guide?
There is much overlap between the OA guide and the package template, so in the long term it might be good not to have both. However, is there feature parity? Is a migration needed? Should we formally deprecate astropy-template and ask people to migrate? Or should we simply not update it any longer? Or maybe keep both because they are different?
MHvK: can we perhaps make a migration guide? And then deprecate the astropy template?
The discussion in the issue is stalled, so it seems good to bring it up here to make a decision or suggestion on how to proceed.

  • The package_template does not always reflex the newest and best CI practices, e.g. GH actions. Have to manually update dependent packages.
    • Is there a way to automate this? We’ve done some in package_template, but it has fallen somewhat by the wayside
  • What about dependent packages? How to migrate?
  • The OpenAstronomy template requires more understanding and work. package_template “just works”
  • The OA template doesn’t have the Astropy infrastructure.
  • What about moving the package_template to OA and then the Astropy template uses the OA template, adding the Astropy infrastructure stuff
    • How to keep the Astropy one up-to-date? Who does this?
    • Can cookiecutter manage this?
  • Next steps:
    • Message in package_template that we are considering a move to OA template
    • Recommending to OA in the meantime
    • Add documentation how to add Astropy infrastructure on top of OA
    • Funded project proposal for keeping these steps up-to-date, or ideally making a sub-branch or “astropy method” in the OA package template.
@weaverba137
Copy link
Member

One comment about the Python Packaging Guide: entire top-level sections of the documentation "Needs writing!". Literally: https://packaging-guide.openastronomy.org/en/latest/scripts.html. I would be hesitant to recommend the template until at least all documentation is filled in.

@pllim
Copy link
Member

pllim commented Feb 8, 2022

Good point, @weaverba137 ! I opened issue at OpenAstronomy/packaging-guide#23. cc @Cadair

@Cadair
Copy link
Member

Cadair commented Feb 8, 2022

PRs welcome ;) (you could always just remove the placeholders then you never would have complained 😉 )

@pllim
Copy link
Member

pllim commented Feb 8, 2022

just remove the placeholders

As in, completely remove those pages?

@weaverba137
Copy link
Member

I think the documentation of command-line scripts is quite important, and should be filled out rather than removed.

@Cadair
Copy link
Member

Cadair commented Feb 11, 2022

I think the documentation of command-line scripts is quite important, and should be filled out rather than removed.

Not suggesting it isn't.

@pllim
Copy link
Member

pllim commented Sep 6, 2022

What about this? https://github.com/scikit-hep/cookie

@pllim
Copy link
Member

pllim commented Apr 17, 2023

I merged #520 but the OpenAstronomy needs to find someone to clean up the template documentation over there.

@pllim
Copy link
Member

pllim commented Aug 11, 2023

It's been a while since we started this, so I upgraded the "pending deprecation warning" to "deprecation warning" in README. I will also close issues and PRs not related to the transition as won't fix to drive the point across.

@pllim pllim closed this as completed Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants