Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tox] astropy should be listed at "package versions" section rather than at the top #27

Closed
bsipocz opened this issue Nov 8, 2020 · 5 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@bsipocz
Copy link
Member

bsipocz commented Nov 8, 2020

This is not really a pytest-astropy-header issues, but an issue for a lot of coordinated/affiliated packages. E.g. astruqery uses the header properly, it's astroquery's version listed at the top, but other packages have astropy's version there rather than their own.
So the task here is to go through those coordinated packages and fix them, e.g. with batchpr.

E.g. this is expected:

platform darwin -- Python 3.8.0, pytest-6.0.1, py-1.9.0, pluggy-0.13.1

Running tests with astroquery version 0.4.2.dev6444_testrun.
Running tests in astroquery docs.

Date: 2020-11-07T23:21:54

Platform: macOS-10.13.6-x86_64-i386-64bit

Executable: /Users/bsipocz/.pyenv/versions/3.8.0/bin/python

Full Python Version: 
3.8.0 (default, Dec 26 2019, 15:55:54) 
[Clang 10.0.0 (clang-1000.11.45.5)]

encodings: sys: utf-8, locale: UTF-8, filesystem: utf-8
byteorder: little
float info: dig: 15, mant_dig: 15

Package versions: 
Numpy: 1.19.2
Matplotlib: 3.3.2
Astropy: 4.2rc1
APLpy: not available
pyregion: not available
pyVO: 1.1
astropy-helpers: 4.0.1

Using Astropy options: remote_data: none.

But this is what I see:

Running tests with Astropy version 4.2rc1.
Running tests in reproject docs.

Date: 2020-11-07T23:32:17

Platform: macOS-10.13.6-x86_64-i386-64bit

Executable: /Users/bsipocz/.pyenv/versions/3.8.0/bin/python3.8

Full Python Version: 
3.8.0 (default, Dec 26 2019, 15:55:54) 
[Clang 10.0.0 (clang-1000.11.45.5)]

encodings: sys: utf-8, locale: UTF-8, filesystem: utf-8
byteorder: little
float info: dig: 15, mant_dig: 15

Package versions: 
Numpy: 1.19.2
Scipy: 1.5.2
Matplotlib: 3.3.2
h5py: 2.10.0
Pandas: 0.25.3

Using Astropy options: remote_data: none.

Packages with this problem include, but not limited to: reproject, photutils, regions

@pllim pllim added the bug Something isn't working label Nov 9, 2020
@pllim
Copy link
Member

pllim commented Nov 9, 2020

I thought @larrybradley said he fixed it for photutils, except when running things with tox, see astropy/photutils#1046 .

Could this be a duplicate of astropy/package-template#439 ?

@larrybradley
Copy link
Member

I didn't fix anything. My test showed it works fine when running pytest locally, but not with tox. The CI uses tox, so this is still a frustration.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 9, 2020

Oh, I didn't search for issues outside this repo, merely tried to report all the things I run into while cutting the RC.

@pllim
Copy link
Member

pllim commented Dec 4, 2020

This remains a confusing bug. I see that it doesn't work for some people using tox but it works properly when one of my simpler package uses this and tox. Not sure what is causing it.

@pllim pllim changed the title astropy should be listed at "package versions" section rather than at the top [tox] astropy should be listed at "package versions" section rather than at the top Dec 4, 2020
@pllim pllim added the duplicate This issue or pull request already exists label Dec 4, 2020
@pllim
Copy link
Member

pllim commented Dec 4, 2020

Closing as duplicate of #15

@pllim pllim closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants