Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removed subscribe for operation type - retain #188

Closed
wants to merge 2 commits into from

Conversation

kushalnl7
Copy link

Description
Removed subscribe from the Applies to column in the operation binding object.

Related issue(s)
Resolves #187

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kushalnl7 kushalnl7 changed the title Removed subscribe for operation type - retain docs : Removed subscribe for operation type - retain Feb 25, 2023
@kushalnl7 kushalnl7 changed the title docs : Removed subscribe for operation type - retain docs: Removed subscribe for operation type - retain Feb 25, 2023
@kushalnl7 kushalnl7 changed the title docs: Removed subscribe for operation type - retain docs: removed subscribe for operation type - retain Feb 25, 2023
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the version of the binding as well to 0.2.0, just to note, this is a breaking change 🙂

@char0n
Copy link
Collaborator

char0n commented Oct 26, 2023

@kushalnl7 do you need any assistance to push this PR forward? As @jonaslagoni mentioned in #188 (review), we need to bump the binding version as we changed it's behavior by this change.

@derberg
Copy link
Member

derberg commented Dec 4, 2023

no follow ups, closing

@derberg derberg closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT retain flag should be applied only to publish operations
5 participants