Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Bug 🐞 report]: JMS Server Binding Example doesn't match AsyncAPI v3 specification #232

Closed
1 task done
ctasada opened this issue Dec 14, 2023 · 3 comments
Closed
1 task done

Comments

@ctasada
Copy link

ctasada commented Dec 14, 2023

Describe the bug you found in AsyncAPI Docs.

The https://github.com/asyncapi/bindings/blob/master/jms/README.md#examples shows

servers:
  production:
    url: jms://my-activemq-broker:61616
    protocol: jms
    protocolVersion: '1.1'
    description: The production ActiveMQ broker accessed via JMS.

If this object is related with https://github.com/asyncapi/bindings/blob/master/jms/README.md#server-object then the description field shouldn't be included (or it's missing from the Server Object definition) Also, the url field doesn't exist anymore in https://www.asyncapi.com/docs/reference/specification/v3.0.0#serverObject being replaced by the hosts field.

Also, the https://github.com/asyncapi/bindings/blob/master/jms/README.md#server-binding-object points to a Schema Array which doesn't exist anymore. Based in the example it probably should refer to a generic Map[string, string] but I may be wrong there.

Attach any resources that can help us understand the issue.

See https://github.com/asyncapi/bindings/blob/master/jms/README.md#examples

The format of https://github.com/asyncapi/bindings/blob/master/jms/README.md#examples-2 also seems broken compared with the provided documentation

Code of Conduct

  • I agree to follow this project's Code of Conduct
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Dec 14, 2023

@rcoppen @SrfHead please have a look folks

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Apr 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants