Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update aws policy statement #256

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

Gadam8
Copy link
Contributor

@Gadam8 Gadam8 commented Jul 23, 2024

Description

The current AWS policy binding configuration doesn't match what is offered by AWS when configuring IAM policies. Condition and Resource are missing and Principal isn't fully fleshed out. This PR addresses this by extending the binding configuration for SNS and SQS.

Related spec JSON schema PR - asyncapi/spec-json-schemas#553

Related issue(s)
N/A

@Pakisan
Copy link
Member

Pakisan commented Aug 6, 2024

@iancooper @dpwdec up!

@dpwdec
Copy link
Collaborator

dpwdec commented Aug 14, 2024

LGTM!

@derberg Is it ok for us to just got ahead and merge this?

@dpwdec dpwdec merged commit ff4ce3f into asyncapi:master Aug 16, 2024
14 checks passed
@derberg
Copy link
Member

derberg commented Aug 20, 2024

@dpwdec if you approve and looks green and you made sure changes (if needed) are reflected in JSON Schema then yes, merge, and I always recommend to do it with /rtm comment

@asyncapi-bot
Copy link
Contributor

Hello, @derberg! 👋🏼

    I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

    At the moment the following comments are supported in pull requests:

    - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet.
    - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
    - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
    - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR. (Currently only works for upstream branches.)
    - `/update` or `/u` - This comment will update the PR with the latest changes from the target branch. Unless there is a merge conflict or it is a draft PR. NOTE: this only updates the PR once, so if you need to update again, you need to call the command again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants